[Review Queue]: ibm-platform-*, dokuwiki, kubes-*, znc, giraph, easyrsa, flannel, ganglia

[Kevin Monroe]

Hi Juju!

Cory, Kostas, Pete, and myself ran through the queue yesterday.  We have
lots of great +1 / promulgation to announce!  Here's the rundown:

Jan 26, 2017:  Cory, Kevin, Kostas, Pete

   -

   IBM-platform-lsf-server
   -

      https://review.jujucharms.com/reviews/18
      -

      Tests passed, +1, promulgated:
      -

         https://jujucharms.com/ibm-platform-lsf-server/
         -

   IBM-platform-lsf-storage
   -

      https://review.jujucharms.com/reviews/36
      -

      This is now taking advantage of a new helper method in the nfsstorage
      interface, which simplified reactive logic quite a bit.
      -

      Tests passed, +1, promulgated:
      -

         https://jujucharms.com/ibm-platform-lsf-storage/
         - IBM-platform-lsf
      - Just a general observation here:  IBM Platform LSF is a 3-charm
      solution.  The 2 charms above join ibm-platform-lsf-master as promulgated
      charms, and the 3 of them would make a great candidate for an
IBM Platform
      LSF bundle.
   -

   Dokuwiki
   -

      https://review.jujucharms.com/reviews/22
      -

      Test was failing on AWS due to service not being exposed, but with
      Adam’s recent update, tests passed, +1, promulgated:
      -

         https://jujucharms.com/dokuwiki/
         -

   Kubernetes-master
   -

      https://review.jujucharms.com/reviews/27
      -

      In this round of review, the authors have addressed the lint errors
      reported.
      -

      Given the charm is tested as part of the respective bundle, it is a
      +1 from me.
      -

   Kubernetes-worker
   -

      https://review.jujucharms.com/reviews/28
      -

      The charm seems to be better tested in the context of the kubernetes
      bundle.
      -

      Minor fixes (lint errors) are needed, -1 for now.
      -

   Kubeapi-load-balancer
   -

      https://review.jujucharms.com/reviews/29?revision=192
      -

      The charm is tested in the context of the kubernetes bundle.
      -

      However, documentation needs more work, -1 for now.
      -

   Znc
   -

      https://review.jujucharms.com/reviews/24
      -

      Tests passed, +1, promulgated:
      -

         https://jujucharms.com/znc/
         -

   Giraph
   -

      https://review.jujucharms.com/reviews/82
      -

      We think this subordinate charm should be standalone, and so created
      a PR for the author’s consideration.
      -

   easyrsa
   -

      https://review.jujucharms.com/reviews/31
      -

      Tests from the layer are excluded, so the built charm does not have
      any tests.
      -

      -1 for now.
      -

   Flannel
   -

      https://review.jujucharms.com/reviews/30
      -

      Found two small issues related to tests and idempotency.
      -

      -1 for now.
      -

   Ganglia
   -

      https://review.jujucharms.com/reviews/50
      -

      Bundletester failed due to missing PyYAML in venv. This could be an
      env issue on our part, but -1 while we wait for author input.
      -

   IBM-platform-rtm
   -

      https://review.jujucharms.com/reviews/35?revision=71
      -

      This charm deploys IBM platform on ppc64le.
      -

      Reviewing the code brought up a few points that need to be addressed
      by the author:
      -

         Manually altering IPTables
         -

         Stopping services not owned by the charm
         -

         Syntactic errors
         -

      -1 while we wait for author input.


Jan 19, 2017:  Kostas

   -

   Kubernetes-worker
   -

      https://review.jujucharms.com/reviews/28?revision=144
      -

      The charm seems to be better tested in the context of the kubernetes
      bundle.
      -

      There is a test failing and there are also some lint errors.
      - We will have to wait for the author’s input.



Questions/concerns? Please find us on Freenode in #juju.

Thanks!
-Kevin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20170127/c68b1fd8/attachment.html>