[Review Queue] giraph, ghost, charmscaler, ibm-was-nd-dm, ibm-dsm-enterprise, ibm-cinder-storewize, ibm-was-nd-node

[Cory Johns]

Greetings!

Kevin, Pete, Konstantinos, and I got in our time on the queue this week:

March 2, 2017

   -

   giraph
   -

      https://review.jujucharms.com/reviews/82
      -

      PR from last week was approved by the author.
      -

      Deployed fine and tests passed.  Congrats!  +1 and promulgated to:
      -

         http://jujucharms.com/giraph
         -

   ghost
   -

      https://review.jujucharms.com/reviews/94
      -

      Resource update, approved and released
      -

      Because of the consistent quality of Adam’s charm, I have also
      granted him access to update the promulgated Ghost charm in the future
      without going through the RQ.  Congrats!
      -

   charmscaler
   -

      https://review.jujucharms.com/reviews/96
      -

      Looks great, +1
      -

      Made one minor request to ease running the test out of the box, but
      am happy to promulgate if there’s another +1
      -

   ibm-was-nd-dm
   -

      https://review.jujucharms.com/reviews/60
      -

      Disapproved, due to inappropriate handling of admin passwords when
      none is specified.
      -

   ibm -dsm-enterprise
   -

      https://review.jujucharms.com/reviews/57?revision=133
      -

      We asked the author to share the binaries needed to deploy and review
      the charm.
      -

      While going through the code we spotted a few points that would need
      to be addressed for the next review round (copyright, default passwords)
      -

   Ibm-cinder-storewize
   -

      https://review.jujucharms.com/reviews/67?revision=152
      -

      Tests do not currently execute (need to be marked as executable, and
      include a routine that runs the tests).
      -

      Otherwise, the code looks good.
      -

   Ibm-was-nd-node
   -

      https://review.jujucharms.com/reviews/61
      -

      We did a code review and run the test of this charm.
      -

      The author should address the issues we brought forward before we
      move on with this charm.
      -

   Ibm-cinder-ds8k (design review)
   -

      https://review.jujucharms.com/reviews/75
      -

      Design looks solid -- approved the design review
      -

   Ibm-cinder-flashsystem-0 (design review)
   -

      https://review.jujucharms.com/reviews/76
      -

      The design looks good -- gave it a +1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20170302/f754ab1a/attachment.html>