[Bug 104837] Re: kernel warns BUG: at fs/inotify.c:172 set_dentry_child_flags()

[Tim Gardner]

SRU Justification

Impact: There is a race between setting an inode's children's "parent
watched" flag when placing the first watch on a parent, and
instantiating new children of that parent: a child could miss having its
flags set by set_dentry_child_flags, but then inotify_d_instantiate
might still see !inotify_inode_watched.

Patch Description: The solution is to set_dentry_child_flags after
adding the watch.  Locking is taken care of, because both
set_dentry_child_flags and inotify_d_instantiate hold dcache_lock and
child->d_locks.

Patches: http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-
hardy.git;a=commit;h=ab67a74144886e464f5b905558876145e711f17a,
http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-
hardy.git;a=commit;h=670dcd8597ed0aa7f68d05d384226bdb81b0e956

Test Case: See bug description.

-- 
kernel warns BUG: at fs/inotify.c:172 set_dentry_child_flags()
https://bugs.launchpad.net/bugs/104837
You received this bug notification because you are a member of Kernel
Bugs, which is subscribed to Linux.