[Bug 77734] Re: Disk Read Errors during boot-time caused by probe of invalid partitions

[TJ]

Confirmed as still affecting Jaunty by report in bug #329880.

It appears Linus Torvalds rejected my patch when it was pushed from
Andrew Morton's -mm tree to mainline in May 2007:

-----------------------------
From: 	akpm at linux-foundation.org
To: 	linux at tjworld.net, mm-commits at vger.kernel.org
Subject: 	- filesystem-disk-errors-at-boot-time-caused-by-probe.patch removed from -mm tree
Date: 	Tue, 08 May 2007 19:34:23 -0700 (Wed, 03:34 BST)

The patch titled
     filesystem: Disk Errors at boot-time caused by probe of partitions
has been removed from the -mm tree.  Its filename was
     filesystem-disk-errors-at-boot-time-caused-by-probe.patch

This patch was dropped because it was nacked

-----------------------------
From: 	Linus Torvalds <torvalds at linux-foundation.org>
To: 	akpm at linux-foundation.org
Cc: 	linux at tjworld.net, bunk at stusta.de, Jens Axboe <jens.axboe at oracle.com>
Subject: 	Re: [patch 012/455] filesystem: Disk Errors at boot-time caused by probe of partitions
Date: 	Tue, 8 May 2007 09:19:32 -0700 (PDT) (17:19 BST)

On Tue, 8 May 2007, akpm at linux-foundation.org wrote:
>
> From: TJ <linux at tjworld.net>

I don't really like these kinds of addresses. Who is TJ? When I google for 
that name, I find a lot of hits, but all the links to tjworld.net are 
down.

I also think the patch is wrong.

IIRC, we cannot trust the "capacity" data, because not all disks report it 
correctly. If we did, we'd just do the check in read_dev_sector() instead.

So I'm dropping this. I might be wrong about the capacity thing, we may 
have fixed it (Jens cc'd). But if the capacity is trustworthy, why not 
just do the trivial check in read_dev_sector to protect against invalid 
extended ones? And in add_partitions()?

                Linus
-----------------------------


** Changed in: linux (Ubuntu)
     Assignee: (unassigned) => TJ (intuitivenipple)
       Status: New => Confirmed

-- 
Disk Read Errors during boot-time caused by probe of invalid partitions
https://bugs.launchpad.net/bugs/77734
You received this bug notification because you are a member of Kernel
Bugs, which is subscribed to Linux.