[PATCH] USB stress test failure on AMD SB600

[Huang, Shane]

The third patch http://marc.info/?l=linux-usb&m=120469059715031&w=2
has been added to linus source tree too, which is:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e82cc1288fa57857c6af8c57f3d07096d4bcd9d9

But there is some small difference between them,
the latter(git commit) also modified another line as below:

@@ -781,7 +811,7 @@ static int ehci_urb_enqueue (
 static void unlink_async (struct ehci_hcd *ehci, struct ehci_qh *qh)
 {
        /* failfast */
- if (!HC_IS_RUNNING(ehci_to_hcd(ehci)->state))
+ if (!HC_IS_RUNNING(ehci_to_hcd(ehci)->state) && ehci->reclaim)
                end_unlink_async(ehci);

        /* if it's not linked then there's nothing to do */

Can you also modify it? I will NOT do any special backport for this line alone.


Again, two patches plus one line modification should be added to fix the bug:
1. SBX00_USB_hang_fix_Ubuntu.patch
2. SBX00_USB_hang_fix_Ubuntu_new.patch
3. The above one line modification.


Thanks
Shane
 

> -----Original Message-----
> From: Huang, Shane 
> Sent: Friday, March 07, 2008 10:39 AM
> To: Stefan Bader; kernel-team at lists.ubuntu.com
> Cc: Zhao, Richard; Huang, Shane
> Subject: RE: [PATCH] USB stress test failure on AMD SB600
> 
> 
> Linux USB guys submit another patch to make things better:
> http://marc.info/?l=linux-usb&m=120469059715031&w=2
> 
> And that new patch can also replace this one:
> http://lkml.org/lkml/2008/2/19/546
> 
> So, I backported and attached this new patch here.
> Can you apply it as well as the previous patch?
> You need apply the previous patch at first, then this one.
> 
> The bugzilla has been updated too:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/198619
> 
> 
> Please also note that these two backported patched is needed
> only if your kernel <= 2.6.24, because they will be included from
> kernel 2.6.25
> 
> 
> > -----Original Message-----
> > From: Stefan Bader [mailto:stefan.bader at canonical.com] 
> > 
> > 
> > Shane, do we have any positive feedback, that those patches 
> really fix
> > the problem? If I understood the related kernel bugzilla 
> > correctly, this is still work in progress.
> 
> Stefan:
> 
> 
> Those three patches
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.g
> it;a=commitdiff;h=07d29b63ef6b39963ab37818653284d861cf55af
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.g
> it;a=commitdiff;h=f8fa7571a928d6d0e1b7444b0ea69ec7dc7db3b6
> http://marc.info/?l=linux-usb&m=120469059715031&w=2
> have been proved work well on our platforms, so we hope you can
> add them(backported into two patches) if your kernel <= 2.6.24.
> otherwise we may miss the boat of Ubuntu 8.04
> 
> It seems that the debug of this issue is coming to an end after the
> discussion with the driver maintainer David Brownell
> 
> After you added our two backported patches, we will ask our QA to
> continue to test on your new Alpha/Beta release.
> 
> 
> Thanks
> Shane
>