iscsitarget shipped with Ubuntu's linux-image

Stefan Bader stefan.bader at canonical.com
Mon Nov 17 18:46:45 UTC 2008


Arne Redlich wrote:
> Am Montag, den 17.11.2008, 18:35 +0100 schrieb Stefan Bader:
> 
> The patch looks rather good, in particular the modifications to blockio
> I had forgotten to check in the ubuntu kernel package.
> 
> But the point is that this very issue was already fixed - slightly
> differently - shortly after (or even before?) the 2.6.24 release in our
> upstream repository. Hence my proposal of more collaboration instead of
> this duplication of effort.
> 

Hi Arne,

sure thing. I am sorry this went this way. Still have to separate the necessary 
from the cosmetically parts (I believe only the bits below should matter, but 
thats only a quick guess.
As for the coordination part, I agree and we should hopefully do better for Jaunty.

Stefan


-	/* Ignore partials */
-	if (bio->bi_size)
-		return;
-

@@ -215,6 +215,7 @@ static void digest_data(struct hash_desc

  	assert(count <= ISCSI_CONN_IOV_MAX);

+	sg_init_table(sg, ARRAY_SIZE(cmnd->conn->hash_sg));
  	crypto_hash_init(hash);

  	for (i = 0; size; i++) {
@@ -228,6 +229,8 @@ static void digest_data(struct hash_desc
  		offset = 0;
  	}

+	sg_mark_end(&sg[i - 1]);
+
  	crypto_hash_update(hash, sg, nbytes);




More information about the kernel-team mailing list