[Hardy LPIA LUM]: RealTek hda-intel volume remapping for non-linear volume scales

[Colin Ian King]

On Wed, 2009-04-22 at 01:48 +0100, Andy Whitcroft wrote:
> On Tue, Apr 21, 2009 at 04:51:21PM +0100, Colin Ian King wrote:
> 
> > It's good to know your eye is keen... 
> > 
> > The fact is that slave_put_val() requires a master->val to be set for
> > the volume to be set correctly (this case a remapped version). However
> > master->val can be interrogated later for the master volume setting, and
> > we need to return the expected value and not the remapped value else we
> > get ALSA confused. Without a major rewrite of slave_put_xval() I cannot
> > see around this.
> 
> Which lock is protecting master->val for the duration of the update, ie.
> while it is holding the bodged value to prevent alsa seeing it?

Andy, you are 100% right in questioning this. Attached is corrected
version containing a mutex to protect the master value in the
master_get()/master_put() functions. 


-- 
Colin King   <colin.king at canonical.com>
"Me transmitte sursum, caledoni" 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-UBUNTU-SAUCE-hda-intel-volume-remapping-for-non-li.patch
Type: text/x-patch
Size: 7896 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20090422/f5b57c66/attachment.bin>