[Jaunty SRU] LP#345710 [v2: description modified] iwl3945: cancel rfkill_poll with sync when?the module is exiting

[Stefan Bader]

Huaxu Wan wrote:
> Hi Stefan,
> 
> The patch is fine for me. It works for 2.6.28 kernel. But, this bug is
> not found with 2.6.30 or above kernel. This patch is not valuable to
> 2.6.30+, but 2.6.28 stable. I have no idea about whether it should be
> send to upstream. Please do it if you want.
> 

Hi Huaxu,

how stupid of me. I guess we can forget about moving he cancel statement. I 
still have to get it verified but looking at the upstream code we got the 
following patch which moves ieee80211_unregister_hw from below stopping the 
rfkill_poll to above. And (though I did not follow the code completely) it 
seems likely that ieee80211_unregister_hw could call iwl3945_mac_stop which 
restarts the delayed work.
That patch went in after 2.6.29-rc2 and the one doing the cancel as sync after 
2.6.30-rc1. So the final fix is/was with 2.6.30.
Does this sound reasonable?

Regards,
Stefan

-- 

When all other means of communication fail, try words!


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-iwl3945-release-resources-before-shutting-down.patch
Type: text/x-diff
Size: 1548 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20090701/bcd00ea6/attachment.patch>