[Jaunty] SRU modprobe -r iwl3945 causes total system freeze

Colin Ian King colin.king at canonical.com
Fri Jul 3 08:49:08 UTC 2009


On Thu, 2009-07-02 at 11:40 +0200, Stefan Bader wrote:
> SRU Justification:
> 
> Impact: Removing the iwl3945 module can cause a hard lockup of the system as 
> there is a race condition which might get the rfkill_poll workqueue 
> restarted/running after the module code has been unloaded.
> 
> Fix: Two patches from upstream, the first moving the call that restarts the 
> workqueue on the way down to be executed before stopping the workqueue. The 
> second patch makes the call stopping the workqueue wait for any running worker.
> 
> Testcase: Removing and loading the module in a loop (has been verified to be 
> working after the patches being applied).
> 
ACK, looks reasonable to me. 
> 
-- 
Colin King   <colin.king at canonical.com>
"Me transmitte sursum, caledoni" 





More information about the kernel-team mailing list