[Jaunty] Proposing some ext4 patches

Stefan Bader stefan.bader at canonical.com
Mon Jun 22 17:39:12 UTC 2009


After we had https://bugs.launchpad.net/bugs/389555 I had a look at Ted's 
2.6.28-stable repo to figure out, whether there might be some more dangers 
lurking. Since his 2.6.28.10 tag there are 21 patches difference between our 
and his ext4 tree. Quite a few of them are in a gray zone of being of little 
risk but do not seem to be critical enough to qualify for SRU. This would leave 
7 (or 8) which we probably should consider...
And (question to the SRU team) if we do, could we use one tracking report?

Stefan

01
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=1a29ba346699cd47c1b3f683340290f705cd9880
Oops when running without journal. Maybe unlikely case but also low risk as it 
only adds two checks for no journal.

02
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=626be33b682d1d99bfae4ee4db16ed34f6c8ff65
Fsck errors caused by a change which we imported with the last stable import.

03 (maybe skip (not enough justification))
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=7aaeda34909c571d0b8cc8a8a10e788e4e3350be
Limit the rate a warning is printed to 1.

04
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=7956e0d6d07b7f0448085184dc47ce01143f7746
Oops as a result of a bogus BUG_ON

05 (suggest skip)
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=774c43079ddc04a92030dd31109421518e1fcf14
Modifications to avoid lock contention.

06 (maybe skip (not enough justification))
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=be79df89cf61466bbaa97ceb363719b65dc1efd6
Prevent FTBS with CONFIG_OCFS2_COMPAT_JBD enabled (disabled in ubuntu)

07 (suggest skip)
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=acf4d672af6e588d977a6daaad1057977659fcfa
Fix the accidental inheritance of the TOPDIR flag.

08 (suggest skip)
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=c687585c0afac3269bd819df9072a0212762f0d9
Tightens restriction of flags allowed to set on inodes.

09 (maybe (maybe skip (not enough justification))skip (not enough justification))
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=94921a80dc2146b6be4d645db744dd3de0d02eed
Fix up a bogus/confusing error message in some cases. This only changes an 
error code propagated incorrectly to user-space which results in a message 
pointing to NFS.

10 (maybe skip (not enough justification))
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=7c2e96ee2e535566cf87527c000b919341de53d6
Documentation only fix.

11 (?)
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=d9ec01eafda7ec7b5fd63b623c86bd95dbd8349a
Fix to not discard preallocations on close. Not sure of the impact here.

12 (suggest skip)
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=2cd9869ec423014e6b4456010a5bee263bc52478
Adding a mount option to disable the automatic allocation of blocks that would 
normally have delayed allocation on trusted systems. Better performance but 
less safe.

13 (maybe skip (not enough justification))
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=3c5c47493f5300bb08a93158ed43c7ae4064a455
Check for valid modes when reading an inode from disk. Helps to detect corruption.

14 (maybe skip (not enough justification))
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=9a4d680efe0da896450296bf0ee68a406aa3d5e7
Commentary only update.

15
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=3a78d23b7d81cca4779fef150df1fdb7fe5a0547
Fixes wrong memory free

16 (maybe skip (not enough justification))
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=f8e79c5df0d76de38cc46329ce8f9a89a1af222f
Prevent a message (intended to be printed only once) from being printed repeatedly.

17
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=84e7f33aa99698f905a31030717b89ebf3ed0300
Prevents soft lockup by checking the range of i_file_acl.

18 (maybe skip (not enough justification))
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=903865dc2b2bc0bec333cf8ceb55df8703be3807
Ingore the i_file_acl_high unless the filesystem is 64bit (INCOMPAT_64BIT set)

19
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=9bf7b8126ad4a0fc2792532404f667dcf8410917
Prevent possible data corruption on partial writes with preallocation.

20 (maybe skip)
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=2742d4833ba07f06a18ad2df750b9f3a712864a4
Use a large (non-zero) block number for delayed allocation buffers. Those 
should never be written but if this is tried it is more obvious where this 
comes from.

21
http://kernel.ubuntu.com/git?p=smb/ubuntu-jaunty.git;a=commitdiff;h=5ac67d1e8d50b0633361ed2b9ff3834a0998d214
Prevent an invalid combination of flags when converting uninitialized extends 
to initialized ones.

-- 

When all other means of communication fail, try words!






More information about the kernel-team mailing list