[JAUNTY SRU] lp#368809 Make ignore_nice_load setting of ondemand work as expected.

Tim Gardner tim.gardner at canonical.com
Tue Jun 23 16:32:48 UTC 2009


Manoj Iyer wrote:
> SRU JUSTIFICATION
> 
> IMPACT: ondemand micro-accounting of idle time changes broke 
> ignore_nice_load sysfs setting due to a thinko in the code.
> 
> FIX: http://bugzilla.kernel.org/show_bug.cgi?id=12310 backport/cherry-pick 
> to Jaunty.
> 
> TEST: Originator of the bug tested the kernel in 
> http://people.ubuntu.com/~manjo/lp368809-jaunty/ and reported to work.
> 
> 
> The following changes since commit 
> 8d6d84357a3631767f391571e8741c95d829a92d:
>    Stefan Bader (1):
>          UBUNTU: Forgotten update to control files
> 
> are available in the git repository at:
> 
>    git://kernel.ubuntu.com/manjo/ubuntu-jaunty.git lp368809
> 
> Venkatesh Pallipadi (1):
>        [CPUFREQ] Make ignore_nice_load setting of ondemand work as 
> expected.
> 
>   drivers/cpufreq/cpufreq_ondemand.c |   47 
> +++++++++++++++++++----------------
>   1 files changed, 25 insertions(+), 22 deletions(-)
> 
> From ec3d58dfd8feaba042db86463ae468cd1a11801e Mon Sep 17 00:00:00 2001
> From: Venkatesh Pallipadi <venkatesh.pallipadi at intel.com>
> Date: Fri, 23 Jan 2009 09:25:02 -0500
> Subject: [PATCH] [CPUFREQ] Make ignore_nice_load setting of ondemand work as expected.
> 
> ondemand micro-accounting of idle time changes broke ignore_nice_load
> sysfs setting due to a thinko in the code.
> 
> The bug entry:
> http://bugzilla.kernel.org/show_bug.cgi?id=12310
> 
> Reported-by: Jim Bray <jimsantelmo at gmail.com>
> 
> Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi at intel.com>
> Signed-off-by: Dave Jones <davej at redhat.com>
> (cherry picked from commit 1ca3abdb6a4b87246b00292f048acd344325fd12)
> 
> Signed-off-by: Manoj Iyer <manoj.iyer at canonical.com>
> ---
>   drivers/cpufreq/cpufreq_ondemand.c |   47 +++++++++++++++++++----------------
>   1 files changed, 25 insertions(+), 22 deletions(-)
> 

NACK - this is one of those cases where I'm perfectly happy to have the
user run a recent upstream kernel. While somewhat annoying, I don't
think it falls into the class of "OMG kitten killer".

-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list