[PATCH] UBUNTU: AUFS -- Fix header files inclusion in debug.h

Stefan Bader stefan.bader at canonical.com
Wed Feb 10 09:48:56 UTC 2010


Mirsal Ennaime wrote:
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/517151
> 
> The aufs module fails to build with CONFIG_AUFS_DEBUG=y
> The issue is not present in lucid because the whole driver code was synced
> with the upstream aufs tree.
> 
> As I discussed with Andy Whitcroft on IRC, I'm not sure it justifies an SRU,
> as it is unlikely that anyone would really want to build aufs with debugging
> support from the karmic kernel sources package.

I guess I am with Tim. Don't think anybody would really care. It is probably
stretching SRU policy a bit, but it fixes a real bug (even if it is not
happening in our build). And it should really make no difference to have more
headers included (for other cases). I will take it now and have a look when it
compiles.


> Signed-off-by: Mirsal Ennaime <mirsal.ennaime at gmail.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>
> ---
>  ubuntu/aufs/debug.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/ubuntu/aufs/debug.h b/ubuntu/aufs/debug.h
> index dab15f7..d22aff8 100644
> --- a/ubuntu/aufs/debug.h
> +++ b/ubuntu/aufs/debug.h
> @@ -25,9 +25,10 @@
> 
>  #ifdef __KERNEL__
> 
> +#include <asm/system.h>
>  #include <linux/bug.h>
>  /* #include <linux/err.h> */
> -/* #include <linux/init.h> */
> +#include <linux/init.h>
>  /* #include <linux/kernel.h> */
>  #include <linux/delay.h>
>  /* #include <linux/kd.h> */





More information about the kernel-team mailing list