[Maverick][PATCH] drm/radeon/kms: add ioport register access
Tim Gardner
tim.gardner at canonical.com
Thu Jul 8 12:43:11 UTC 2010
On 07/08/2010 05:26 AM, Alberto Milone wrote:
> Hi all,
>
> The attached patch fixes an issue when trying to access NB_MISC
> registers on rs780/rs880 devices. The main problem is that they are
> only accessible via I/O, rather than MMIO. This makes HDMI work
> flawlessly here.
>
> The patch is available in the drm-radeon-testing branch, therefore it
> should make it into 2.6.36:
> http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=shortlog;h=refs/heads/drm-radeon-testing
>
> Please consider accepting this patch in Maverick.
>
> Thanks,
>
>
What happens in radeon_device_fini() on an ATOM platform when
rdev->rio_mem==NULL ? I think pci_iounmap() will crash. Shouldn't it be:
if (rdev->rio_mem)
pci_iounmap(rdev->pdev, rdev->rio_mem);
rtg
--
Tim Gardner tim.gardner at canonical.com
More information about the kernel-team
mailing list