[PATCH 2/3] UBUNTU: SAUCE: smsc95xx: fix macaddr parameter parsing

[Bryan Wu]

Sebjan,

Why call this patch 'UBUNTU: SAUCE'? It is supposed to be upstream. I saw your
patches in netdev mail list. Except that, I am OK for this patch.

Acked-by: Bryan Wu <bryan.wu at canonical.com>

Thanks
-Bryan

On 07/13/2010 11:22 AM, Bryan Wu wrote:
> From: Sebastien Jan <s-jan at ti.com>
> 
> Depending on the position of the macaddr parameter in the command
> line, it could be badly interpreted and discarded.
> 
> Signed-off-by: Sebastien Jan <s-jan at ti.com>
> ---
>  drivers/net/usb/smsc95xx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
> index 0ba06d9..8a4d92b 100644
> --- a/drivers/net/usb/smsc95xx.c
> +++ b/drivers/net/usb/smsc95xx.c
> @@ -677,7 +677,7 @@ static int smsc95xx_is_macaddr_param(struct usbnet *dev, u8 *dev_mac)
>  		}
>  	}
>  
> -	if (j == MAC_ADDR_LEN && !macaddr[i]) {
> +	if (j == MAC_ADDR_LEN) {
>  		netif_dbg(dev, ifup, dev->net, "Overriding MAC address with: "
>  		"%02x:%02x:%02x:%02x:%02x:%02x\n", mtbl[0], mtbl[1], mtbl[2],
>  						mtbl[3], mtbl[4], mtbl[5]);