[APPLIED] Re: [MAVERICK SAUCE] UBUNTU: SAUCE: Add support for Intellimouse Mode in ALPS touchpad on Dell E2 series Laptops

[Leann Ogasawara]

Applied to Maverick linux master.

Thanks,
Leann

On Thu, 2010-09-09 at 10:08 -0500, manoj.iyer at canonical.com wrote:
> I ran checkpatch.pl and it generated 3 warning, I am ignoring the "line 
> over 80 characters warning"...
> 
> WARNING: line over 80 characters
> #106: FILE: drivers/input/mouse/alps.c:179:
> +                               rc = 
> alps_model_init_quirk_tbl[i].callback(psmouse);
> 
> WARNING: suspect code indent for conditional statements (24, 8)
> #155: FILE: drivers/input/mouse/psmouse-base.c:661:
>                          if (!set_properties || alps_init(psmouse) == 0)
> +       /* If ALPS model quirk was applied, don't change the settings */
> 
> WARNING: line over 80 characters
> #158: FILE: drivers/input/mouse/psmouse-base.c:663:
> +                               return psmouse->type ? psmouse->type : 
> PSMOUSE_ALPS;
> 
> total: 0 errors, 3 warnings, 119 lines checked
> 
> ./0001-UBUNTU-SAUCE-Add-support-for-Intellimouse-Mode-in-AL.patch has 
> style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> I fixed warning #158, and pushed to remote repo. Modified patch attached.
> 
> The following changes since commit 
> 4e90adae43f52db35c99bcaccb2e2a912b8299d5:
>    stanley.miao (1):
>          DSS2: Don't power off a panel twice
> 
> are available in the git repository at:
> 
> 
> git://kernel.ubuntu.com/git/manjo/ubuntu-maverick.git lp632884
> 
> Manoj Iyer (1):
>        UBUNTU: SAUCE: Add support for Intellimouse Mode in ALPS touchpad on 
> Dell E2 series Laptops
> 
>   drivers/input/mouse/alps.c         |   81 
> ++++++++++++++++++++++++++++++++++++
>   drivers/input/mouse/alps.h         |    5 ++
>   drivers/input/mouse/psmouse-base.c |    3 +-
>   3 files changed, 88 insertions(+), 1 deletions(-)
> 
> 
> 
> Cheers
> --- manjo
> 
> On Thu, 9 Sep 2010, Tim Gardner wrote:
> 
> > On 09/08/2010 07:09 PM, Manoj Iyer wrote:
> >> git://kernel.ubuntu.com/git/manjo/ubuntu-maverick.git lp632884
> >> 
> >
> > Other then some minor formatting the patch looks self contained. Can you run 
> > it through checkpatch.pl first? Then perhaps send it back to Rez with the 
> > formatting corrections? Otherwise,
> >
> > Acked-by: Tim Gardner <tim.gardner at canonical.com>
> >
> > -- 
> > Tim Gardner tim.gardner at canonical.com
> >