[PATCH] bounce: call flush_dcache_page after bounce_copy_vec

Eric Miao eric.miao at canonical.com
Mon Sep 13 14:42:44 UTC 2010


On Mon, Sep 13, 2010 at 10:37 PM, Tim Gardner <tim.gardner at canonical.com> wrote:
> On 09/12/2010 11:49 PM, Bryan Wu wrote:
>> From: Gary King<gking at nvidia.com>
>>
>> the bounced page needs to be flushed after data is copied into it,
>> to ensure that architecture implementations can synchronize
>> instruction and data caches if necessary.
>>
>> This patch was posted at armlinux mail list and was asked by Andrew
>> Morton and Jens Axboe. We tried this patch and found is fixed memtester
>> issue.
>> (http://lists.infradead.org/pipermail/linux-arm-kernel/2010-September/025373.html)
>>
>> BugLink: http://bugs.launchpad.net/bugs/633227
>>
>> Signed-off-by: Gary King<gking at nvidia.com>
>> Tested-by: Ricardo Salveti de Araujo<ricardo.salveti at canonical.com>
>> Tested-by: Sebastien Jan<s-jan at ti.com>
>> Signed-off-by: Bryan Wu<bryan.wu at canonical.com>
>> ---
>>   mm/bounce.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/mm/bounce.c b/mm/bounce.c
>> index 13b6dad..1481de6 100644
>> --- a/mm/bounce.c
>> +++ b/mm/bounce.c
>> @@ -116,8 +116,8 @@ static void copy_to_high_bio_irq(struct bio *to, struct bio *from)
>>                */
>>               vfrom = page_address(fromvec->bv_page) + tovec->bv_offset;
>>
>> -             flush_dcache_page(tovec->bv_page);
>>               bounce_copy_vec(tovec, vfrom);
>> +             flush_dcache_page(tovec->bv_page);
>>       }
>>   }
>>
>
> As this was so enthusiastically endorsed by upstream I've applied this
> to ti-omap4 and have also requested a pre-stable pull request for
> Maverick master.
>

Yep. <stable at kernel.org> is actually Cc'ed in the original patch, so this
definitely applies to the stable. Possibly to both lucid and maverick.

The merged commit in Linus' tree is:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=ac8456d6f9a3011c824176bd6084d39e5f70a382

> applied to ti-omap4
>
> --
> Tim Gardner tim.gardner at canonical.com
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>




More information about the kernel-team mailing list