[LUCID] [SRU] [PATCH 0/2] Enable model 9240 MegaRaid SAS Controlers

[Stefan Bader]

On 09/23/2010 04:30 PM, Brad Figg wrote:
> On 09/23/2010 12:34 AM, Stefan Bader wrote:
>> On 09/23/2010 03:09 AM, Brad Figg wrote:
>>> SRU Justification
>>>
>>> Impact: The upstream process for stable tree updates is quite similar
>>> in scope
>>> to the Ubuntu SRU process, e.g., each patch has to demonstrably fix a
>>> bug, and
>>> each patch is vetted by upstream by originating either directly from
>>> Linus'
>>> tree or in a minimally backported form of that patch.
>>>
>>> The 2.6.33.y upstream stable tree contains two commits which enable
>>> the megaraid_sas
>>> driver to recognise the new models of MegaRaid SAS controllers at
>>> issue in this
>>> bug report.
>>>
>>
>> You are (assuming without realizing) cheating here. Yes, those two
>> patches can
>> be found when looking at the 2.6.33.y tree. But that does not make
>> them stable
>> updates. In fact those two were part of 2.6.33-rc1, not stable.
>>
>> The two look harmless enough but I would think we should at least make an
>> attempt to submit them for 2.6.32.y.
>>
>>> TEST CASE:
>>> Two commits from the 2.6.33.y tree were applied to a Lucid test build
>>> and tested
>>> by at least one subscriber to this bug who verified it resolved the
>>> issue for
>>> them.
>>>
>>> Brad Figg (1):
>>>    UBUNTU: SAUCE: [SCSI] megaraid_sas: allocate the application cmds to
>>>      sas2 controller
>>>
>>
>> Beside of that, having you as author seems a bit odd. Was there a lot
>> of change
>> required (backport)?
>>
>>> Yang, Bo (1):
>>>    UBUNTU: SAUCE: [SCSI] megaraid_sas: Add new megaraid SAS 2 controller
>>>      support to the driver
>>
>> Generally, I don't think both of these should be marked SAUCE (or even
>> UBUNTU)
>> as they origin from upstream. Again, it seems to make sense to at
>> least try to
>> argue with Greg (maybe with help of the author) about those. They even
>> have been
>> tested.
>>
>> -Stefan
>>
>>>
>>>   drivers/scsi/megaraid/megaraid_sas.c |  163
>>> ++++++++++++++++++++++++++++++++--
>>>   drivers/scsi/megaraid/megaraid_sas.h |    5 +
>>>   2 files changed, 160 insertions(+), 8 deletions(-)
>>>
>>>
>>
> 
> Stefan,
> 
> You are correct. The two commits that I picked from the 2.6.33.y stable
> tree did
> not come in as a result of a stable update but as part of the 2.6.33
> development
> cycle.
> 
> However, I was not trying in any way to deceive anyone here. I simply
> didn't do
> all the homework that I should have and so the justification doesn't
> accurately
> represent how the patches got into the tree.
> 
> Brad

I probably should not try to be funny early on. I did not want to give the
impression you try to do something stealthy. It rather should have been a
pointer that this is not (yet) a real stable patch and we should work on that
and even if failing to get it there should be careful or more correct with
provenance and references.
So sorry for the harsh sounding tone.

-Stefan