[Hardy] CVE-2010-4247: XEN: Add yield points to blktap and blkback

[Stefan Bader]

On 08.06.2011 02:28, John Johansen wrote:
> On 06/07/2011 09:19 AM, Tim Gardner wrote:
>> On 06/07/2011 08:52 AM, Stefan Bader wrote:
>>> On 01.06.2011 16:06, Stefan Bader wrote:
>>>> As far as I can see this only affects Hardy as that is the only
>>>> place that creates a dom0 kernel. The code itself seems to be
>>>> present in the lucid-ec2 tree, but as we do not support dom0 and
>>>> those are drivers for that. So I set the Lucid-ec2 status to
>>>> not-affected, but I am thinking of adding the changes anyway, just
>>>> in case...
>>>>
>>>> -Stefan
>> <snip>
>>>
>>> Pushing this one as I did not see any replies, yet.
>>>
>>> -Stefan
>>>
>>
>> It didn't get reviewed because I couldn't figure out what you wanted. As far as I can tell you're _thinking_ of adding changes to drivers that are not in fact even used, nor will they _ever_ be used since we won't have a Lucid DOM0 host unless we provide one via an LTS backported kernel. In which case the point is moot.
>>
> As I read it, this is for Hardy where we do have dom0, and not Lucid because we don't support dom0 there.
> 
> My big question when looking at the patch was why combine the two patches its based off?  I found it hard to look at and compare the patch that way.
> 

Mostly because generating new patches for the custom binary build is a pita. And
then one patch added some blkback parts which the second partially corrected and
additionally added them to blktap. So I was slightly lazy there with the slight
(imo) benefit of having a patch that adds the same code patterns to two files.

-Stefan