[Acked] [PATCH] Revert: "dell-laptop: Toggle the unsupported hardware killswitch"

Keng-Yü Lin kengyu at canonical.com
Wed Jun 29 16:58:46 UTC 2011


On Wed, Jun 29, 2011 at 3:50 PM, Leann Ogasawara
<leann.ogasawara at canonical.com> wrote:
> On Mon, 2011-06-27 at 18:01 +0100, Keng-Yu Lin wrote:
>> This reverts commit a3d77411e8b2ad661958c1fbee65beb476ec6d70,
>>
>> as it causes a mess in the wireless rfkill status on some models.
>> It is probably a bad idea to toggle the rfkill for all dell models
>> without the respect to the claim that it is hardware-controlled.
>>
>> BugLink: http://bugs.launchpad.net/bugs/775281
>>
>> Signed-off-by: Keng-Yu Lin <kengyu at canonical.com>
>
> As this appears to cause a widespread regression for multiple dell
> models, it makes sense to revert.  Will a new patch be sent to fix the
> original issue on the Dell Inspiron 1018?  eg some sort of model
> specific quirk?
>
> Acked-by: Leann Ogasawara <leann.ogasawara at canonical.com>

Yeah, this is a nice suggestion. I can work on adding the quirk
support in dell-laptop.c and quirk Inspiron 1018 there. think also a
good idea to wait until my revert patch really merged upstream.

  Thanks,
-kengyu




More information about the kernel-team mailing list