[PATCHv2 0/4] [Maverick SRU] Enable hotkeys for Asus EEE PC

[Brad Figg]

On 03/02/2011 06:20 PM, Keng-Yü Lin wrote:
> On Thu, Mar 3, 2011 at 5:01 AM, Tim Gardner<tim.gardner at canonical.com>  wrote:
>> On 03/02/2011 01:53 PM, Tim Gardner wrote:
>>> Applied with minor editorial changes. For example, upstream is not
>>> linux-next. Only Linus' tree is considered upstream in the context of
>>> SRUs and cherry-picking. Therefore, I've changed the commit subject
>>> accordingly:
>>>
>>> UBUNTU: SAUCE: eeepc-wmi: set the touchpad toggle key code to F22
>>> UBUNTU: SAUCE: (drop after 2.6.38) eeepc-wmi: add wlan key found on 1015P
>>> UBUNTU: SAUCE: (drop after 2.6.38) eeepc-wmi: reorder keymap
>>> eeepc-wmi: add additional hotkeys
>>>
>>> I've also committed the 2 linux-next patches from Corentin Chary to
>>> Natty. I still need to know if your F22 patch is needed for Natty.
>>>
>>> rtg
>>
>> Oh, and don't forget to write the SRU justification in the bug report.
>>
>
> Upstream is more comfortable with a dedicated key code
> KEY_TOUCHPAD_TOGGLE now. I've sent a patch for that in upstream.
> udev should bridge the key mapping for user space. This commit should
> make it work in Natty:
>
>    http://git.kernel.org/?p=linux/hotplug/udev.git;a=commit;h=0d8b6be5f5238360d2d8e220d6da280f842c5358
>
> So I think we do not need the F22 sauce patch for Natty. It should be
> taken care by udev keymaps.
>
> SRU justification is in the cover letter of the patchset. You like it
> in LP Bug report, too?
>
> -kengyu
>

Kengyu,

Yes, every SRU needs to have a buglink in the commit body which yours
does have.

The bug pointed to by the buglink needs to have the SRU justification
text in the same format. This is looked at by the SRU team.

We probably have this documented somewhere on a wiki page but I can't
find it right now. I may have to create such a wiki page.

Brad
-- 
Brad Figg brad.figg at canonical.com http://www.canonical.com