[PATCH 1/2] UBUNTU: SAUCE: vesafb: mtrr module parameter is uint, not bool

Brad Figg brad.figg at canonical.com
Thu May 19 14:20:44 UTC 2011


On 05/19/2011 06:54 AM, Andy Whitcroft wrote:
> From: Thomas Schlichter<thomas.schlichter at web.de>
>
> BugLink: http://bugs.launchpad.net/bugs/778043
>
> As noted by the reporter the mtrr kernel command line option is actually a
> positive numeric not a boolean, move the module parameter we add to match.
>
> Signed-off-by: Andy Whitcroft<apw at canonical.com>
> ---
>   drivers/video/vesafb.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/vesafb.c b/drivers/video/vesafb.c
> index 2a60213..d0db4bb 100644
> --- a/drivers/video/vesafb.c
> +++ b/drivers/video/vesafb.c
> @@ -74,7 +74,7 @@ module_param_named(vgapal, pmi_setpal, invbool, 0);
>   MODULE_PARM_DESC(vgapal, "Use VGA for setting palette (default)");
>   module_param_named(pmipal, pmi_setpal, bool, 0);
>   MODULE_PARM_DESC(pmipal, "Use PMI for setting palette");
> -module_param(mtrr, bool, 0);
> +module_param(mtrr, uint, 0);
>   MODULE_PARM_DESC(mtrr, "Enable MTRR support (default)");
>   module_param_named(nomtrr, mtrr, invbool, 0);
>   MODULE_PARM_DESC(nomtrr, "Disable MTRR support");

Acked-by: Brad Figg <brad.figg at canonical.com>

Andy,

Don't forget to add the SRU justification text.

Brad
-- 
Brad Figg brad.figg at canonical.com http://www.canonical.com




More information about the kernel-team mailing list