[PATCH 3/3] benet: remove bogus "unlikely" on vlan check
Brad Figg
brad.figg at canonical.com
Tue Feb 14 21:20:08 UTC 2012
From: Jiri Pirko <jpirko at redhat.com>
CVE-CVE-2011-3347
BugLink: http://bugs.launchpad.net/bugs/880893
Use of unlikely in this place is wrong. Remove it.
Signed-off-by: Jiri Pirko <jpirko at redhat.com>
Signed-off-by: David S. Miller <davem at davemloft.net>
(cherry picked from commit 343e43c02850a3abcd22bd144e5bdbc92fdd273c)
Signed-off-by: Brad Figg <brad.figg at canonical.com>
---
drivers/net/benet/be_main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c
index bf8d198..c258fae 100644
--- a/drivers/net/benet/be_main.c
+++ b/drivers/net/benet/be_main.c
@@ -1195,7 +1195,7 @@ static void be_rx_compl_process(struct be_adapter *adapter,
skb->rxhash = rxcp->rss_hash;
- if (unlikely(rxcp->vlanf))
+ if (rxcp->vlanf)
__vlan_hwaccel_put_tag(skb, rxcp->vlan_tag);
netif_receive_skb(skb);
@@ -1252,7 +1252,7 @@ static void be_rx_compl_process_gro(struct be_adapter *adapter,
if (adapter->netdev->features & NETIF_F_RXHASH)
skb->rxhash = rxcp->rss_hash;
- if (unlikely(rxcp->vlanf))
+ if (rxcp->vlanf)
__vlan_hwaccel_put_tag(skb, rxcp->vlan_tag);
napi_gro_frags(&eq_obj->napi);
--
1.7.5.4
More information about the kernel-team
mailing list