ACK w/comment: [Oneiric SRU] drm/i915: Fix PCH port pipe select in CPT disable paths

Stefan Bader stefan.bader at canonical.com
Mon Jan 2 16:17:27 UTC 2012


On 20.12.2011 09:15, Keng-Yu Lin wrote:
> SRU Justification:
> 
> Impact:
>   The external monitor becomes blank at times on extended or mirror mode.
> 
> Fix:
>   Upstream commit 1519b9956eb4b4180fa3f47c73341463cdcfaa37
>   with some conflicts resolved.

In cases where I had to resolve conflicts, I would flag this as
"backported from commit x" in the patch.

> 
> Testcase:
>   Tested on Asus K54C, both analog VGA and HDMI ports work good.

Since 3.0 is also still on support upstream, I think it would make sense to send
your backport to stable at vger.kernel.org with cc to Keith and a Tested-by line
added with a little comment what roughly had to be adapted and that you think
this would make a good stable candidate for 3.0.y.

Otherwise looks like the upstream change and you can verify it, so

Acked-by: Stefan Bader <stefan.bader at canonical.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/906756
> 
> Keith Packard (1):
>   drm/i915: Fix PCH port pipe select in CPT disable paths
> 
>  drivers/gpu/drm/i915/i915_reg.h      |   13 ++----
>  drivers/gpu/drm/i915/intel_display.c |   81 +++++++++++++++++++++++++++++++---
>  2 files changed, 79 insertions(+), 15 deletions(-)
> 





More information about the kernel-team mailing list