Backporting the HDA Jack sense patches to Precise

[David Henningsson]

On 01/03/2012 03:46 PM, Leann Ogasawara wrote:
> On Tue, 2012-01-03 at 11:44 +0100, David Henningsson wrote:
>> A follow-up to the earlier thoughts about having the new jack detection
>> interface in Precise. [1] Takashi has now merged the code into his main
>> branch, which means it'll make it into 3.3. I think now would be a good
>> time to start testing/backporting it into the Precise kernel.
>>
>> Is there anything I need to know about how do we go about this? I was
>> thinking to do this:
>>
>> 1) I'll export the relevant patches from Takashi's tree with git
>> format-patch
>
> You may want to cherry-pick instead.
>
>> 2) I'll create a local branch of the Precise git tree and applying them
>> one by one, backporting/changing as necessary
>
> For tracking purposes, if you do cherry-pick, could you use the -x
> option.  Could you also be sure also modify the commit message to note
> which git repo it was cherry-picked from, eg:
>
> (cherry-picked from<sha1>  git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
>
> In the event that the patch does not cherry-pick cleanly, could you
> modify the commit message to note it's a backport rather than a clean
> cherry-pick, eg:
>
> (backported from<sha1>  git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
>
>> 3) I'll build a test kernel
>> 4) I'll test the new feature on at least two machines I have here and
>> confirm that it works.
>> 5) I'll push the branch for review/inclusion into a public tree at
>> kernel.ubuntu.com.
>>
>> Does this seem reasonable?
>
> Sounds fine.

Ok, I have now done this. I've tested the new kernel on two machines, on 
which I've tested analog playback, auto-mute, HDMI playback and a quick 
recording test as well. No regressions were found - in fact, these 
patches also improve the old jack detection interface, so PulseAudio 
works better already. :-)

For reference, one machine had a Realtek codec and Nvidia for HDMI, and 
the other Sigmatel codec and Intel for HDMI.

The branch you want to review/include is at 
http://kernel.ubuntu.com/git?p=diwic/ubuntu-precise.git;a=shortlog;h=refs/heads/jack-detection-backport

-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic