ACK: [PATCH 1/1] PCI: Allow pcie_aspm=force to work even when FADT indicates it is unsupported

[Stefan Bader]

On 30.03.2012 12:13, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+bug/962038
> 
> Right now using pcie_aspm=force will not enable ASPM if the FADT indicates
> ASPM is unsupported.  However, the semantics of force should probably allow
> for this, especially as they did before the ASPM disable rework with commit
> 3c076351c4027a56d5005a39a0b518a4ba393ce2
> 
> This patch just skips the clearing of any ASPM setup that the firmware has
> carried out on this bus if pcie_aspm=force is being used.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  drivers/pci/pcie/aspm.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> index 2275162..c73ed00 100644
> --- a/drivers/pci/pcie/aspm.c
> +++ b/drivers/pci/pcie/aspm.c
> @@ -790,6 +790,9 @@ void pcie_clear_aspm(struct pci_bus *bus)
>  {
>  	struct pci_dev *child;
>  
> +	if (aspm_force)
> +		return;
> +
>  	/*
>  	 * Clear any ASPM setup that the firmware has carried out on this bus
>  	 */

It sounds like it will then do more like one does expect from a force semantics.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20120330/1992e6bb/attachment.sig>