[Acked/cmt] [Quantal linux-meta] Prevent linux-crashdump from replacing grub-efi

[Andy Whitcroft]

On Tue, Oct 09, 2012 at 12:22:07PM +0200, Stefan Bader wrote:
> BugLink: http://bugs.launchpad.net/bugs/1064259
> 
> When playing with linux-crashdump on an EFI installed system I realized
> that grub-efi was thrown away and replaced by grub-pc which did not
> seem to good.
> 
> Apparently we do not consider grub-efi as an alternative in the
> depends. With this added (I took the version of grub-efi in Lucid)
> at least grub-efi remains installed and a normal boot still works.
> 
> Only the actual crash-dump seems to explode on this system with
> backtraces showing a log of xhci... /me bangs head.
> 
> Still it sounds like we probably want to add this to meta packages
> for P and L at least.. and Q of course...

It cirtainly seems inappropriate to be removing grub-efi to install
anything, ever :).

> 
> From 1b53289d1e4be597b2d865d0ed89465853ee2950 Mon Sep 17 00:00:00 2001
> From: Stefan Bader <stefan.bader at canonical.com>
> Date: Tue, 9 Oct 2012 11:31:30 +0200
> Subject: [PATCH] UBUNTU: Ubuntu-3.5.0.17.19
> 
> Signed-off-by: Stefan Bader <stefan.bader at canonical.com>
> ---
>  meta-source/debian/changelog      |    7 +++++++
>  meta-source/debian/control.common |    2 +-
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-source/debian/changelog b/meta-source/debian/changelog
> index bb83f7a..47edf88 100644
> --- a/meta-source/debian/changelog
> +++ b/meta-source/debian/changelog
> @@ -1,3 +1,10 @@
> +linux-meta (3.5.0.17.19) quantal-proposed; urgency=low
> +
> +  * Make linux-crashdump alternatively depend on grub-efi.
> +    LP: #1064259
> +
> + -- Stefan Bader <stefan.bader at canonical.com>  Tue, 09 Oct 2012 11:28:08 +0200
> +
>  linux-meta (3.5.0.17.18) quantal-proposed; urgency=low
>  
>    * Add new meta-packages for linux-signed-* images.
> diff --git a/meta-source/debian/control.common b/meta-source/debian/control.common
> index 725b34d..5273800 100644
> --- a/meta-source/debian/control.common
> +++ b/meta-source/debian/control.common
> @@ -36,7 +36,7 @@ Description: Generic Linux kernel image.
>  Package: linux-crashdump
>  Architecture: i386 amd64
>  Section: devel
> -Depends: ${misc:Depends}, kexec-tools, makedumpfile, grub-pc (>= 1.96+20090611-1ubuntu2) | grub (>= 0.97-29ubuntu24)
> +Depends: ${misc:Depends}, kexec-tools, makedumpfile, grub-pc (>= 1.96+20090611-1ubuntu2) | grub-efi (>= 1.98-1ubuntu5) | grub (>= 0.97-29ubuntu24)

How did you choose this version of grub-efi, it seems arbitrary from
outside.

But asssuming that this is a meaningful version:

Acked-by: Andy Whitcroft <apw at canonical.com>

-apw