[Acked/cmt] [PATCH] UBUNTU: SAUCE: alx: disables MSI generation

Andy Whitcroft apw at canonical.com
Fri Apr 19 09:55:01 UTC 2013


On Fri, Apr 19, 2013 at 09:50:26AM +0800, AceLan Kao wrote:
> BugLink: http://bugs.launchpad.net/bugs/927782
> 
> Compared the alx driver with the working one in
> compat-wireless-3.6.8-1 and found we need this flag to make the
> driver works for the chip revision less than C0.
> 
> Signed-off-by: AceLan Kao <acelan.kao at canonical.com>
> ---
>  ubuntu/alx/alx_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ubuntu/alx/alx_main.c b/ubuntu/alx/alx_main.c
> index 7fe3f4b..700ebf1 100644
> --- a/ubuntu/alx/alx_main.c
> +++ b/ubuntu/alx/alx_main.c
> @@ -1026,6 +1026,7 @@ static int alx_identify_hw(struct alx_adapter *adpt)
>  		if (rev < ALX_REV_C0) {
>  			hw->ptrn_ofs = 0x600;
>  			hw->max_ptrns = 8;
> +			pdev->dev_flags |= PCI_DEV_FLAGS_MSI_INTX_DISABLE_BUG;
>  		} else {
>  			hw->ptrn_ofs = 0x14000;
>  			hw->max_ptrns = 16;

Minimal fix, looks to do what is claimed.  Assuming this has been tested
to fix the 15 machines in question and has been tested on something
which is not those 15 machines with alx then:

Acked-by: Andy Whitcroft <apw at canonical.com>

-apw




More information about the kernel-team mailing list