[kteam-tools][PATCH 0/3] notify-stable-review enhancements

[Luis Henriques]

Kamal Mostafa <kamal at canonical.com> writes:

> New optional command-line flags for notify-stable-review, useful for
> recovering from a partially busted run.
>
> notify-stable-review
>
>     --sent_cover_letter=<Message-Id>
> 		 (Optional and unusual) Assumes the cover letter has
> 		 already been sent as <Message-Id>, so passes that to
> 		 git-send-email as the --in-reply-to to be used (and
> 		 does not generate another cover letter).
>
>     --edit_patch_dir
> 		 Starts a subshell in the directory of generated
> 		 patches just before sending to allow edits or
> 		 selective removal.
>
>
> Kamal Mostafa (3):
>   notify-stable-review: factor out generate_cover_letter()
>   notify-stable-review: implement --sent-cover-letter=<Message-Id>
>   notify-stable-review: implement --edit_patch_dir
>
>  stable/notify-stable-review | 181 ++++++++++++++++++++++++++++----------------
>  1 file changed, 117 insertions(+), 64 deletions(-)

This looks like a sensible solution for sorting out the cases where
the script fails for some reason.  I can only remember to see this
script failing once (UTF encoding of authors name, IIRC).
Fortunately, I found this problem while running the script with
--dry-run so I manually fixed the patch.

Although the stats are a little bit scary, most of the changes seem to
be code churn.

Looking at the code, I couldn't find any issues so if you've tested it
(I didn't!) feel free to push it.  Also, could you please update
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable/Maintenance to
include a small section describing the usage of these new options?

Cheers,
-- 
Luis