[PATCH 1/3 Raring SRU] ALSA: hda - Add power state filtering

[Jason DeRose]

So the 3rd commit (17df3f55652f7ea8fb1197b5c32e227b3da9f215) is written against
a version of snd_hda_codec_set_power_to_all() that takes 3 arguments, whereas
the current version of snd_hda_codec_set_power_to_all() in raring takes 4 args.

The 1st commit (9419ab6b72325e20789a61004cf68dc9e909a009) is what changed the
snd_hda_codec_set_power_to_all() function signature.  So although you can
cleanly cherry-pick just the 2nd and 3rd, you'll get a build failure.

----- Original Message -----
From: "Tim Gardner" <tim.gardner at canonical.com>
To: "Seth Forshee" <seth.forshee at canonical.com>
Cc: "Takashi Iwai" <tiwai at suse.de>, kernel-team at lists.ubuntu.com
Sent: Monday, August 5, 2013 2:37:56 AM
Subject: Re: [PATCH 1/3 Raring SRU] ALSA: hda - Add power state filtering

On 08/05/2013 09:03 AM, Seth Forshee wrote:
> On Sun, Aug 04, 2013 at 03:59:27AM -0600, Tim Gardner wrote:
>> From: Takashi Iwai <tiwai at suse.de>
>>
>> BugLink: http://bugs.launchpad.net/bugs/1183125
>>
>> Add a hook to struct hda_codec for filtering the target power state of
>> each widget when powering up/down.  The current hackish EAPD check is
>> implemented as the default hook pointer, too.
>>
>> This allows codec drivers to implement own power filter.  In the
>> upcoming changes, the generic parser will have the better power filter
>> based on the active paths.
>>
>> Signed-off-by: Takashi Iwai <tiwai at suse.de>
>> (cherry picked from commit 9419ab6b72325e20789a61004cf68dc9e909a009)
>>
>> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
>
> This patch looks like it should have no functional change, and I don't
> think either of the subsequent patches depend on it. It looks safe
> enough, but it does contain a fair amount of churn. Are you sure this
> one is needed?
>
> Seth
>

I was basing the first commit on the info in 
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1183125/comments/5 
- so perhaps the simplest fix is just patch 2 & 3.

rtg

-- 
Tim Gardner tim.gardner at canonical.com

-- 
kernel-team mailing list
kernel-team at lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team