[ 3.5.y.z extended stable ] Patch "ALSA: rme32.c irq enabling after spin_lock_irq" has been added to staging queue
Luis Henriques
luis.henriques at canonical.com
Tue Feb 26 16:13:28 UTC 2013
This is a note to let you know that I have just added a patch titled
ALSA: rme32.c irq enabling after spin_lock_irq
to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree
which can be found at:
http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.5.y-queue
If you, or anyone else, feels it should not be added to this tree, please
reply to this email.
For more information about the 3.5.y.z tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable
Thanks.
-Luis
------
>From 8ac4e4f000885aa1a9d7eacf79362e6e3df9cc6b Mon Sep 17 00:00:00 2001
From: Denis Efremov <yefremov.denis at gmail.com>
Date: Mon, 11 Feb 2013 19:04:06 +0400
Subject: [PATCH] ALSA: rme32.c irq enabling after spin_lock_irq
commit f49a59c4471d81a233e09dda45187cc44fda009d upstream.
According to the other code in this driver and similar
code in rme96 it seems, that spin_lock_irq in
snd_rme32_capture_close function should be paired
with spin_unlock_irq.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Denis Efremov <yefremov.denis at gmail.com>
Signed-off-by: Takashi Iwai <tiwai at suse.de>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
sound/pci/rme32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/rme32.c b/sound/pci/rme32.c
index 46b3629..f1dec07 100644
--- a/sound/pci/rme32.c
+++ b/sound/pci/rme32.c
@@ -1017,7 +1017,7 @@ static int snd_rme32_capture_close(struct snd_pcm_substream *substream)
spin_lock_irq(&rme32->lock);
rme32->capture_substream = NULL;
rme32->capture_periodsize = 0;
- spin_unlock(&rme32->lock);
+ spin_unlock_irq(&rme32->lock);
return 0;
}
--
1.8.1.2
More information about the kernel-team
mailing list