ACK: [PATCH 0/1][quantal/raring] Fix broken backlight controls on Samsung N250P

Colin Ian King colin.king at canonical.com
Mon Jan 7 15:25:53 UTC 2013


On 07/01/13 15:16, Seth Forshee wrote:
> I had expected to see this patch in 3.8, but it seems no pull request
> was sent for platform-drivers-x86. It's a trivial patch to add a quirk
> for this machine and has an ack from the samsung-laptop maintainer, so
> it's just a matter of time before it gets upstream. I propose we carry
> it as a sauce patch until that happens.
>
>
> == SRU Justification ==
>
> Impact: The standard ACPI backlight interfaces on this machine fail to
> change the screen brightness. There is an alternate interface supported
> by the samsung-laptop module that does work, but since userspace prefers
> acpi_video the hotkeys and UI for adjusting screen brightness fail to
> work.
>
> Fix: This problem is common enough on Samsung machines that
> samsung-laptop contains a dmi list of machines which need the acpi_video
> backlight disabled. Add this machine to that list.
>
> Test Case: Using a driver with the quirk added results in working
> backlight controls. Tested on LP#1086921.
>
>
> Seth Forshee (1):
>    UBUNTU: SAUCE: samsung-laptop: Add quirk for broken acpi_video
>      backlight on N250P
>
>   drivers/platform/x86/samsung-laptop.c |   10 ++++++++++
>   1 file changed, 10 insertions(+)
>
This is restricted to a specific piece of hardware and looks OK to me,

Acked-by: Colin Ian King <colin.king at canonical.com>





More information about the kernel-team mailing list