[Acked] [PATCH 1/1] power: bq27541 driver - serialize get_property

Alex Hornung alex at alexhornung.com
Tue Jan 29 20:03:02 UTC 2013


Hi Andy,

thanks.

On 29/01/13 19:52, Andy Whitcroft wrote:
> This is probabally a rather large hammer for the task, but it does seem
> to prevent parallel i2c transactions and serialise the data as well.

It sure is. Fact is that the driver is a mess as it stands, and could do
with a complete rewrite. However, that is more effort than I am willing
to put into this.

> Alex, I assume you are upstreaming this in parallel.

Yes, now that I know which one the upstream that your kernel is based on
is, I'll get the patches upstream - that is, once I figure out how that
"repo" script submits things into android's gerrit. Same goes for the
other patch.

> Overall assuming this passes testing it seems that it should be low
> risk.

Gema did some test runs on this - it gets rid of the spurious values she
was getting, and everything else works as before.

Cheers,
Alex




More information about the kernel-team mailing list