[ 3.8.y.z extended stable ] Patch "ARM: 7778/1: smp_twd: twd_update_frequency need be run on all online" has been added to staging queue

Kamal Mostafa kamal at canonical.com
Tue Jul 16 22:54:03 UTC 2013


This is a note to let you know that I have just added a patch titled

    ARM: 7778/1: smp_twd: twd_update_frequency need be run on all online

to the linux-3.8.y-queue branch of the 3.8.y.z extended stable tree 
which can be found at:

 http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.8.y-queue

This patch is scheduled to be released in version 3.8.13.5.

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.8.y.z tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Kamal

------

>From 9a7cd8342d52b7f3534cbd1494b78708365f2391 Mon Sep 17 00:00:00 2001
From: Jason Liu <r64343 at freescale.com>
Date: Mon, 1 Jul 2013 09:53:30 +0100
Subject: ARM: 7778/1: smp_twd: twd_update_frequency need be run on all online
 CPUs

commit cbbe6f82b489e7ceba4ad7c833bd3a76cd0084cb upstream.

When the local timer freq changed, the twd_update_frequency function
should be run all the CPUs include itself, otherwise, the twd freq will
not get updated and the local timer will not run correcttly.

smp_call_function will run functions on all other CPUs, but not include
himself, this is not correct,use on_each_cpu instead to fix this issue.

Cc: Linus Walleij <linus.walleij at linaro.org>
Cc: Rob Herring <rob.herring at calxeda.com>
Cc: Shawn Guo <shawn.guo at linaro.org>
Cc: Arnd Bergmann <arnd at arndb.de>
Acked-by: Linus Walleij <linus.walleij at linaro.org>
Acked-by: Shawn Guo <shawn.guo at linaro.org>
Signed-off-by: Jason Liu <r64343 at freescale.com>
Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
---
 arch/arm/kernel/smp_twd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
index 49f335d..64ac3f1 100644
--- a/arch/arm/kernel/smp_twd.c
+++ b/arch/arm/kernel/smp_twd.c
@@ -121,7 +121,7 @@ static int twd_rate_change(struct notifier_block *nb,
 	 * changing cpu.
 	 */
 	if (flags == POST_RATE_CHANGE)
-		smp_call_function(twd_update_frequency,
+		on_each_cpu(twd_update_frequency,
 				  (void *)&cnd->new_rate, 1);

 	return NOTIFY_OK;
--
1.8.1.2





More information about the kernel-team mailing list