[ 3.5.y.z extended stable ] Patch "ASoC: max98088 - fix element type of the register cache." has been added to staging queue

Luis Henriques luis.henriques at canonical.com
Mon Jul 29 15:33:55 UTC 2013


This is a note to let you know that I have just added a patch titled

    ASoC: max98088 - fix element type of the register cache.

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:

 http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Luis

------

>From 19fc11dc1463728d1fff05582f4738562351b194 Mon Sep 17 00:00:00 2001
From: Chih-Chung Chang <chihchung at chromium.org>
Date: Mon, 15 Jul 2013 09:38:46 -0700
Subject: [PATCH] ASoC: max98088 - fix element type of the register cache.

commit cb6f66a2d278e57a6c9d8fb59bd9ebd8ab3965c2 upstream.

The registers of max98088 are 8 bits, not 16 bits. This bug causes the
contents of registers to be overwritten with bad values when the codec
is suspended and then resumed.

Signed-off-by: Chih-Chung Chang <chihchung at chromium.org>
Signed-off-by: Dylan Reid <dgreid at chromium.org>
Signed-off-by: Mark Brown <broonie at linaro.org>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
 sound/soc/codecs/max98088.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c
index 4790568..8df4597 100644
--- a/sound/soc/codecs/max98088.c
+++ b/sound/soc/codecs/max98088.c
@@ -1594,7 +1594,7 @@ static int max98088_dai2_digital_mute(struct snd_soc_dai *codec_dai, int mute)

 static void max98088_sync_cache(struct snd_soc_codec *codec)
 {
-       u16 *reg_cache = codec->reg_cache;
+       u8 *reg_cache = codec->reg_cache;
        int i;

        if (!codec->cache_sync)
--
1.8.1.2





More information about the kernel-team mailing list