[ 3.5.y.z extended stable ] Patch "rtc: rtc-mv: Add support for clk to avoid lockups" has been added to staging queue

[Jason Cooper]

On Wed, Mar 13, 2013 at 01:45:36PM +0000, Luis Henriques wrote:
> On Wed, Mar 13, 2013 at 09:23:30AM -0400, Jason Cooper wrote:
> > Luis,
> > 
> > On Wed, Mar 13, 2013 at 01:07:47PM +0000, Luis Henriques wrote:
> > > This is a note to let you know that I have just added a patch titled
> > > 
> > >     rtc: rtc-mv: Add support for clk to avoid lockups
> > > 
> > > to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
> > > which can be found at:
> > > 
> > >  http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.5.y-queue
> > > 
> > > If you, or anyone else, feels it should not be added to this tree, please 
> > > reply to this email.
> > > 
> > > For more information about the 3.5.y.z tree, see
> > > https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable
> > > 
> > > Thanks.
> > > -Luis
> > > 
> > > ------
> > > 
> > > From 9630368a7116e76efad66622f6d22758b301e8fc Mon Sep 17 00:00:00 2001
> > > From: Andrew Lunn <andrew at lunn.ch>
> > > Date: Sun, 3 Feb 2013 12:32:06 +0100
> > > Subject: [PATCH] rtc: rtc-mv: Add support for clk to avoid lockups
> > > 
> > > commit 89c58c198b252f2bc20657fdd72a2aea788c435c upstream.
> > > 
> > > The Marvell RTC on Kirkwood makes use of the runit clock. Ensure the
> > > driver clk_prepare_enable() this clock, otherwise there is a danger
> > > the SoC will lockup when accessing RTC registers with the clock
> > > disabled.
> > > 
> > > Reported-by: Simon Baatz <gmbnomis at gmail.com>
> > > Signed-off-by: Andrew Lunn <andrew at lunn.ch>
> > > Tested-by: Simon Baatz <gmbnomis at gmail.com>
> > > Signed-off-by: Jason Cooper <jason at lakedaemon.net>
> > > Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
> > > ---
> > >  arch/arm/boot/dts/kirkwood.dtsi |  1 +
> > >  drivers/rtc/rtc-mv.c            | 28 ++++++++++++++++++++++++----
> > >  2 files changed, 25 insertions(+), 4 deletions(-)
> > 
> > Please drop this patch from the v3.5.x queue.  The Marvell SoCs hadn't
> > converted over to common clock yet.  At best this patch is a no-op, at
> > worst, it breaks the kirkwood.dtsi (there is no label &gate_clk yet).
> 
> Thank you Jason, I'll drop it.  I actually saw your comment regarding
> this patch for the 3.4 kernel and, after taking a look at the code, it
> looked like it could be included in 3.5.  I was wrong :-)

No problem.  Thanks for getting to these so quickly.

thx,

Jason.