ACK: [Lucid] [Patch 1/1] Fix ptrace when task is in task_is_stopped(), state

Stefan Bader stefan.bader at canonical.com
Fri Mar 22 10:31:25 UTC 2013


On 21.03.2013 21:57, John Johansen wrote:
> From d6a1da349c76ac2ebe4774d1da9fb7e660df01d3 Mon Sep 17 00:00:00 2001
> From: John Johansen <john.johansen at canonical.com>
> Date: Thu, 21 Mar 2013 05:04:13 -0700
> Subject: [PATCH] UBUNTU: SAUCE: Fix ptrace when task is in task_is_stopped()
>  state
> 
> This patch fixes a regression in ptrace, introduced by commit 9e74eb39
> (backport of 9899d11f) which makes assumptions about ptrace behavior
> which are not true in the 2.6.32 kernel.
> 
> BugLink: http://bugs.launchpad.net/bugs/1145234
> 
> 9899d11f makes the assumption that task_is_stopped() is not a valid state
> in ptrace because it is built on top of a series of patches which change
> how the TASK_STOPPED state is tracked (321fb561 which requires d79fdd6d
> and several other patches).
> 
> Because Lucid does not have the set of patches that make task_is_stopped()
> an invalid state in ptrace_check_attach, partially revert 9e74eb39 so
> that ptrace_check_attach() correctly handles task_is_stopped(). However
> we must replace the assignment of TASK_TRACED with __TASK_TRACED to
> ensure TASK_WAKEKILL is cleared.
> 
> Signed-off-by: John Johansen <john.johansen at canonical.com>


Ok, it seems the logic reverts back to before task_is_stopped was invalid and
since before it waited for TASK_TRACED later on it looks to be sensible to
switch that to __TASK_TRACED which is used now.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20130322/718273ff/attachment.sig>


More information about the kernel-team mailing list