[ 3.5.y.z extended stable ] Patch "8139cp: Fix skb leak in rx_status_loop failure path." has been added to staging queue

Luis Henriques luis.henriques at canonical.com
Fri Sep 20 19:34:03 UTC 2013


This is a note to let you know that I have just added a patch titled

    8139cp: Fix skb leak in rx_status_loop failure path.

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:

 http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Luis

------

>From dc882f5ee19d0aa8047a9c46814c6bee9d22b55d Mon Sep 17 00:00:00 2001
From: Dave Jones <davej at redhat.com>
Date: Fri, 9 Aug 2013 11:16:34 -0700
Subject: [PATCH] 8139cp: Fix skb leak in rx_status_loop failure path.

commit d06f5187469eee1b2932c02fd093d113cfc60d5e upstream.

Introduced in cf3c4c03060b688cbc389ebc5065ebcce5653e96
("8139cp: Add dma_mapping_error checking")

Signed-off-by: Dave Jones <davej at redhat.com>
Signed-off-by: David S. Miller <davem at davemloft.net>
Signed-off-by: Luis Henriques <luis.henriques at canonical.com>
---
 drivers/net/ethernet/realtek/8139cp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/realtek/8139cp.c b/drivers/net/ethernet/realtek/8139cp.c
index bf8eb57..efd3e34 100644
--- a/drivers/net/ethernet/realtek/8139cp.c
+++ b/drivers/net/ethernet/realtek/8139cp.c
@@ -524,6 +524,7 @@ rx_status_loop:
 					 PCI_DMA_FROMDEVICE);
 		if (dma_mapping_error(&cp->pdev->dev, new_mapping)) {
 			dev->stats.rx_dropped++;
+			kfree_skb(new_skb);
 			goto rx_next;
 		}

--
1.8.3.2





More information about the kernel-team mailing list