[3.11.y.z extended stable] Patch "vfs: allow umount to handle mountpoints without revalidating them" has been added to staging queue

Luis Henriques luis.henriques at canonical.com
Fri Aug 8 08:30:07 UTC 2014


On Fri, Aug 08, 2014 at 08:59:16AM +1000, NeilBrown wrote:
<...>
> > +error_check:
> > +	if (!error) {
> > +		if (!dentry->d_inode) {
> > +			error = -ENOENT;
> > +			dput(dentry);
> > +		} else {
> > +			path->dentry = dentry;
> > +			path->mnt = mntget(nd->path.mnt);
> > +			if (should_follow_link(dentry->d_inode,
> > +						nd->flags & LOOKUP_FOLLOW))
> > +				return 1;
> > +			follow_mount(path);
> > +		}
> 
> Above code is buggy and fixed by 
> 
> commit 295dc39d941dc2ae53d5c170365af4c9d5c16212
> Author: Vasily Averin <vvs at parallels.com>
> Date:   Mon Jul 21 12:30:23 2014 +0400
> 
>     fs: umount on symlink leaks mnt count
> 
> 
> so be sure to include that patch too.
> 
> NeilBrown
> 
>

Ah!  Thanks a lot for catching that.  I'm queuing a backport of the
fix.

Cheers,
--
Luís




More information about the kernel-team mailing list