NAK: [PATCH] [TRUSTY] ahci_xgene: Removing NCQ support from the APM X-Gene SoC AHCI SATA Host Controller driver.

[Dann Frazier]

On Mon, Aug 18, 2014 at 3:07 PM, Chris J Arges
<chris.j.arges at canonical.com> wrote:
> On 08/18/2014 03:54 PM, dann frazier wrote:
>> From: Suman Tripathi <stripathi at apm.com>
>>
>> BugLink: http://bugs.launchpad.net/bugs/1350087
>>
> This bug doesn't include any SRU templating, can you please fill this
> out in the bug report? Also this seems to already have been used for
> another patch, can you perhaps include why there is an additional patch
> needed to fix this bug, or if it is a separate bug file a new one with
> the proper paperwork.

I'll file a new bug and refresh the patch.

>> This patch removes the NCQ support from the APM X-Gene SoC AHCI
>> Host Controller driver as it doesn't support it.
>>
>> Signed-off-by: Loc Ho <lho at apm.com>
>> Signed-off-by: Suman Tripathi <stripathi at apm.com>
>> Signed-off-by: Tejun Heo <tj at kernel.org>
>> Cc: stable at vger.kernel.org
>> (from linux-next; backported to Ubuntu's 3.13)
>
> Can you please include a specific commit that this is backported from?
>  (backported from commit XXXXXXXXXXXXXXXXX)

Sure. But is that useful for linux-next backports?

fyi, this applies to utopic too, but stable was CC'd so I assume it'll
migrate in naturally.

 -dann

> Thanks,
> --chris j arges
>
>> Signed-off-by: dann frazier <dann.frazier at canonical.com>
>> ---
>>  drivers/ata/ahci_xgene.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
>> index ebafa8b..961735d 100644
>> --- a/drivers/ata/ahci_xgene.c
>> +++ b/drivers/ata/ahci_xgene.c
>> @@ -344,8 +344,8 @@ static struct ata_port_operations xgene_ahci_ops = {
>>  };
>>
>>  static const struct ata_port_info xgene_ahci_port_info = {
>> -     AHCI_HFLAGS(AHCI_HFLAG_NO_PMP | AHCI_HFLAG_YES_NCQ),
>> -     .flags = AHCI_FLAG_COMMON | ATA_FLAG_NCQ,
>> +     AHCI_HFLAGS(AHCI_HFLAG_NO_PMP | AHCI_HFLAG_NO_NCQ),
>> +     .flags = AHCI_FLAG_COMMON,
>>       .pio_mask = ATA_PIO4,
>>       .udma_mask = ATA_UDMA6,
>>       .port_ops = &xgene_ahci_ops,
>>
>
>