[3.13.y-ckt stable] Patch "drivers/net: Disable UFO through virtio" has been added to staging queue

Luis Henriques luis.henriques at canonical.com
Tue Dec 9 19:29:47 UTC 2014


On Tue, Dec 09, 2014 at 05:02:11PM +0000, Ben Hutchings wrote:
> On Tue, 2014-12-09 at 08:42 -0800, Kamal Mostafa wrote:
> > On Mon, 2014-12-08 at 20:11 +0000, Ben Hutchings wrote:
> > > On Mon, 2014-12-08 at 12:10 -0800, Kamal Mostafa wrote:
> > > > This is a note to let you know that I have just added a patch titled
> > > > 
> > > >     drivers/net: Disable UFO through virtio
> > > > 
> > > > to the linux-3.13.y-queue branch of the 3.13.y-ckt extended stable tree 
> > > > which can be found at:
> > > > 
> > > >  http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.13.y-queue
> > > > 
> > > > This patch is scheduled to be released in version 3.13.11-ckt13.
> > > > 
> > > > If you, or anyone else, feels it should not be added to this tree, please 
> > > > reply to this email.
> > > [...]
> > > 
> > > You should drop this as part of it needs to be reverted and that patch
> > > hasn't been applied upstream yet.
> > 
> > Okay, I'll drop "Disable UFO through virtio" from 3.13-stable.
> > 
> > But what about this subsequent UFO patch which refers to UFO being 'now
> > disabled'?  Drop this too, or leave it in?:
> > 
> >     drivers/net, ipv6: Select IPv6 fragment idents for virtio UFO packets
> >     
> >     [ Upstream commit 5188cd44c55db3e92cd9e77a40b5baa7ed4340f7 ]
> >     
> >     UFO is now disabled on all drivers that work with virtio net headers,
> >     but userland may try to send UFO/IPv6 packets anyway.  Instead of
> >     sending with ID=0, we should select identifiers on their behalf (as we
> >     used to).
> >     
> >     Signed-off-by: Ben Hutchings <ben at decadent.org.uk>
> >     Fixes: 916e4cf46d02 ("ipv6: reuse ip6_frag_id from ip6_ufo_append_data")
> >     Signed-off-by: David S. Miller <davem at davemloft.net>
> >     Signed-off-by: Kamal Mostafa <kamal at canonical.com>
> > 
> > Thanks very much, Ben!
> 
> That's still a useful fix, but will have some fuzz.
> 
> Ben.

I guess this also applies to the 3.16 kernel as well; I dropped both
patches earlier:

 3d0ad09412ff drivers/net: Disable UFO through virtio
 5188cd44c55d drivers/net, ipv6: Select IPv6 fragment idents for virtio UFO packets

but I should have kept the second one.  I'll queue it again for the
next release.

Cheers,
--
Luís




More information about the kernel-team mailing list