First take on i915_bdw driver

[Tim Gardner]

On 03/20/2014 08:56 AM, Timo Aaltonen wrote:
> On 20.03.2014 04:21, Tim Gardner wrote:
>> On 03/19/2014 11:50 AM, Timo Aaltonen wrote:
>>>
>>> Hi
>>>
>>> So here is the first draft at a separate i915_bdw driver for
>>> Broadwell graphics in trusty kernel. Modeled after i915_hsw as found
>>> on quantal kernel, and adds some cherry-picks from 3.14 to make the
>>> backport easier.
>>>
>>> It's based on current drm-intel-next branch, and it'll most likely
>>> get rebased before the kernel freeze on something closer to what the
>>> actual drm pull request for 3.15-rc1 will be. But this is here now
>>> for the initial review.
>>>
>>> Tested on BDW and non-BDW so that they load the correct driver.
>>>
>>>
>>> git://kernel.ubuntu.com/tjaalton/ubuntu-trusty.git i915-bdw
>>>
>>> c98730dc706bd83 UBUNTU: SAUCE: i915_bdw: Add i915_bdw_gpu_*() calls
>>> for ubuntu/i915 7fcefc7b368d67a UBUNTU: SAUCE: i915_bdw: Only support
>>> Broadwell with ubuntu/i915 driver a3d31f54beffdb1 UBUNTU: SAUCE:
>>> i915_bdw: Add DP_AUX and DP test sink CRC definitions 644101765acdddf
>>> drm: export cmdline and preferred mode functions from fb helper
>>> f9b402b6b03999c drm: add DRM_INFO_ONCE() to print a one-time
>>> DRM_INFO() message 7345cf382e4bef5 UBUNTU: SAUCE: i915_bdw: Revert
>>> "ACPI / i915: replace open-coded _DSM 2b8e96d1b236620 UBUNTU: SAUCE:
>>> i915_bdw: Add an include back to intel_opregion.c 4586122341471d7
>>> drm: Move drm_encoder_crtc_ok() to core 94ff650767e6959 drm: provide
>>> a helper for the encoder possible_crtcs mask c1c886161690c10
>>> drm/i915: add i915_get_reset_stats_ioctl 9d39abbe15a7421 drm/i915:
>>> add i915_reset_count de79c6ce7a83c1e drm: Pass 'flags' from the
>>> caller to .get_scanout_position() ea95a9518c06a40 drm: Pass the
>>> display mode to drm_calc_vbltimestamp_from_scanoutpos()
>>> 01cb4fe9ae89b82 drm: Pass the display mode to
>>> drm_calc_timestamping_constants() 185a9c5b6ccb7b4 drm: expose
>>> subpixel order name routine v3 7a4b5deb15c3b41 UBUNTU: i915_bdw:
>>> [Config] Enable CONFIG_DRM_I915_BDW=m be2cedc67c4f3e7 UBUNTU: SAUCE:
>>> i915_bdw: Update intel_ips.h file location 68665f3db2749eb UBUNTU:
>>> SAUCE: i915_bdw: Rename ubuntu/i915 driver to i915_bdw
>>> fb2b8ff007dcda8 UBUNTU: SAUCE: i915_bdw: Provide an ubuntu/i915
>>> driver for Broadwell graphics
>>>
>>>
>>
>> These commits are erroneously referred to as cherry-picks. I would
>> prefer that you mention from which repository they were cherry-picked,
>> and retitle the patch as 'UBUNTU: SAUCE' until they get merged upstream.
>
> Indeed, some of these will be in 3.15:
>
>> ac1bb36c4e28b53b3494bc8afbe6ffa0588bfe4a 'drm: expose subpixel order
>> name routine v3'
>>
>> 2f1046f304b1ab14ea611a01b85f3486f2b9ce5b 'drm: export cmdline and
>> preferred mode functions from fb helper'
>>
>> a25eebb0afb6d0bebdc86cb1e8e4a6f3dadf266c 'drm: dp helper: Add DP test
>> sink CRC definition.'
>
> but these two are from v3.14:
>
>> 87930dd432406f2f118d9eb26b14cb73f4da2e47 'drm: provide a helper for the
>> encoder possible_crtcs mask'
>>
>> a25d783ec99578d9ae0e91881c29cc4aa71f8676 'drm: Move
>> drm_encoder_crtc_ok() to core'
>
>

I think it likely that your repository is polluted.

rtg at salmon:~/linux/linux$ git log -p 
87930dd432406f2f118d9eb26b14cb73f4da2e47
fatal: bad object 87930dd432406f2f118d9eb26b14cb73f4da2e47
rtg at salmon:~/linux/linux$ git log -p 
a25d783ec99578d9ae0e91881c29cc4aa71f8676
fatal: bad object a25d783ec99578d9ae0e91881c29cc4aa71f8676

> I'll fix those and rebase this with drm-intel-next-queued, which has
> more commits going into 3.15.
>
> thanks!
>
>


-- 
Tim Gardner tim.gardner at canonical.com