[PATCH 3.8 41/81] hwmon: (max1668) Fix writing the minimum temperature

Kamal Mostafa kamal at canonical.com
Tue Mar 25 17:15:54 UTC 2014


3.8.13.20 -stable review patch.  If anyone has any objections, please let me know.

------------------

From: Guenter Roeck <linux at roeck-us.net>

commit 500a91571f0a5d0d3242d83802ea2fd1faccc66e upstream.

When trying to set the minimum temperature, the driver was erroneously
writing the maximum temperature into the chip.

Signed-off-by: Guenter Roeck <linux at roeck-us.net>
Reviewed-by: Jean Delvare <jdelvare at suse.de>
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
---
 drivers/hwmon/max1668.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/max1668.c b/drivers/hwmon/max1668.c
index 666d9f6..4a9f3bc 100644
--- a/drivers/hwmon/max1668.c
+++ b/drivers/hwmon/max1668.c
@@ -243,7 +243,7 @@ static ssize_t set_temp_min(struct device *dev,
 	data->temp_min[index] = SENSORS_LIMIT(temp/1000, -128, 127);
 	if (i2c_smbus_write_byte_data(client,
 					MAX1668_REG_LIML_WR(index),
-					data->temp_max[index]))
+					data->temp_min[index]))
 		count = -EIO;
 	mutex_unlock(&data->update_lock);
 
-- 
1.8.3.2





More information about the kernel-team mailing list