[precise][sru][PATCH 4/5] veth: fix a NULL deref in netif_carrier_off
Chris J Arges
chris.j.arges at canonical.com
Tue Mar 25 21:03:06 UTC 2014
From: Eric Dumazet <edumazet at google.com>
BugLink: http://bugs.launchpad.net/bugs/1201869
In commit d0e2c55e7c94 (veth: avoid a NULL deref in veth_stats_one)
we now clear the peer pointers in veth_dellink()
veth_close() must therefore make sure the peer pointer is set.
Reported-by: Tom Parkin <tom.parkin at gmail.com>
Signed-off-by: Eric Dumazet <edumazet at google.com>
Signed-off-by: David S. Miller <davem at davemloft.net>
(cherry picked from commit 2efd32ee1b60b0b31404ca47c1ce70e5a5d24ebc)
Signed-off-by: Chris J Arges <chris.j.arges at canonical.com>
---
drivers/net/veth.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index f41b98c..e093646 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -207,9 +207,11 @@ static int veth_open(struct net_device *dev)
static int veth_close(struct net_device *dev)
{
struct veth_priv *priv = netdev_priv(dev);
+ struct net_device *peer = rtnl_dereference(priv->peer);
netif_carrier_off(dev);
- netif_carrier_off(rtnl_dereference(priv->peer));
+ if (peer)
+ netif_carrier_off(peer);
return 0;
}
--
1.7.9.5
More information about the kernel-team
mailing list