[Vivid][SRU][PATCH 1/2] net/mlx4_core: double free of dev_vfs

Chris J Arges chris.j.arges at canonical.com
Mon Jul 13 14:20:59 UTC 2015


From: Carol L Soto <clsoto at linux.vnet.ibm.com>

BugLink: http://bugs.launchpad.net/bugs/1473883

If user loads mlx4_core with num_vfs greater than
supported then variable dev->dev_vfs is freed 2 times after unloading the
driver.

Acked-by: Or Gerlitz <ogerlitz at mellanox.com>
Signed-off-by: Carol L Soto <clsoto at linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem at davemloft.net>
(cherry picked from commit 5114a04e6c73a0c6e74737e801b8a3b3d40c7e36)
Signed-off-by: Chris J Arges <chris.j.arges at canonical.com>
---
 drivers/net/ethernet/mellanox/mlx4/main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
index ff2fffe..e25cba1 100644
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -2598,6 +2598,7 @@ disable_sriov:
 free_mem:
 	dev->persist->num_vfs = 0;
 	kfree(dev->dev_vfs);
+        dev->dev_vfs = NULL;
 	return dev_flags & ~MLX4_FLAG_MASTER;
 }
 
-- 
1.9.1





More information about the kernel-team mailing list