ACK: [PATCH 1/2] [Trusty][SRU](upstream) Clean up scsi error messages

Chris J Arges chris.j.arges at canonical.com
Fri Jun 5 13:27:06 UTC 2015


On Fri, Jun 05, 2015 at 12:33:21AM -0500, Dave Chiluk wrote:
> See https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1449372
> 
> There are three commits in play here
> ee60b2c52e -  [SCSI] Add timeout to avoid infinite command retry 
> and
> e6c11dbb8d - scsi_lib: remove the description string in scsi_io_completion()
> 
> I included ee60b2c52e because it's short obvious, and allows e6c11dbb8d to be
> cleanly cherry-picked. This patch is only necessary on Trusty as it already
> exists on utopic+
> 
> e6c11dbb8d, solves part of the issue by removing some
> of the error messages altogether.
> 

These two patches are clean cherry-picks and seem to be a less invasive fix than
9e5ed2a5b3.

--chris


> 
> 9e5ed2a5b3 - scsi: use external buffer for command logging
> 9e5ed2a5b3, I did not include, but wanted to bring up.  It does not cleanly
> cherry-pick, and it appears to have numerous dependencies in order to get
> there.  However, it does seem to actually be the real fix for this problem.
> Please review it and let me know if you agree with my assessment it probably
> doesn't qualify for an SRU.
> 
> Thanks,
> Dave.
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
> 




More information about the kernel-team mailing list