ACK: Ack w/cmnt: [VIVID] [PULL] UBUNTU: arm64: xgene-enet: add SGMII based 1GbE support for the second port

Brad Figg brad.figg at canonical.com
Sun Jun 21 14:21:58 UTC 2015


On Sun, Jun 21, 2015 at 10:25:10AM +0100, Tim Gardner wrote:
> On 06/19/2015 05:21 PM, Brad Figg wrote:
> >
> >1. All are clean cherry-picks.
> >2. All are localized to apm/xgene
> >3. Positive testing.
> >
> >Minor issue: patch 1/11 is a cherry-pick of de7b5b3d790a2524c3f992d357983600635c441b and
> >not b0ab0afaebc88158c02755d2d9a09f1406c82406 which is what the patch says.
> >
> >Brad
> >
> 
> I agree with Brad's assessment, though I have to wonder how you
> managed to substitute an erroneous SHA1 if you are _really_ using
> 'git cherry-pick -x'. I'll find it quite tedious if I now have to
> verify that _every_ patch is indeed a cherry-pick.
> 
> For the record, these patches will disappear when Vivid is rebased
> against 4.2.

For the record, Vivid will NOT be rebased against 4.2. Wily will be.

Brad

> 
> rtg
> -- 
> Tim Gardner tim.gardner at canonical.com

-- 
Brad Figg brad.figg at canonical.com http://www.canonical.com




More information about the kernel-team mailing list