[PATCH 3.13.y-ckt 31/90] selinux: fix sel_write_enforce broken return value

Kamal Mostafa kamal at canonical.com
Tue May 5 20:54:03 UTC 2015


3.13.11-ckt20 -stable review patch.  If anyone has any objections, please let me know.

------------------

From: Joe Perches <joe at perches.com>

commit 6436a123a147db51a0b06024a8350f4c230e73ff upstream.

Return a negative error value like the rest of the entries in this function.

Signed-off-by: Joe Perches <joe at perches.com>
Acked-by:  Stephen Smalley <sds at tycho.nsa.gov>
[PM: tweaked subject line]
Signed-off-by: Paul Moore <pmoore at redhat.com>
Signed-off-by: Kamal Mostafa <kamal at canonical.com>
---
 security/selinux/selinuxfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
index 392ab0f..9977902 100644
--- a/security/selinux/selinuxfs.c
+++ b/security/selinux/selinuxfs.c
@@ -152,7 +152,7 @@ static ssize_t sel_write_enforce(struct file *file, const char __user *buf,
 		goto out;
 
 	/* No partial writes. */
-	length = EINVAL;
+	length = -EINVAL;
 	if (*ppos != 0)
 		goto out;
 
-- 
1.9.1





More information about the kernel-team mailing list