[Vivid][PATCH] UBUNTU: SAUCE: mwifiex: Switch WiFi LED state according to the device status

[Jesse Sung]

2015-11-05 22:45 GMT+08:00 Seth Forshee <seth.forshee at canonical.com>:
> On Thu, Nov 05, 2015 at 05:45:07PM +0800, Jesse Sung wrote:
>> 2015-11-05 0:21 GMT+08:00 Seth Forshee <seth.forshee at canonical.com>:
>> > On Wed, Nov 04, 2015 at 08:27:53PM +0800, Wen-chien Jesse Sung wrote:
>> >> BugLink: https://launchpad.net/bugs/1512997
>> >>
>> >> For Edge Gateway 5000/5100 only.
>> >>
>> >> Add code for controlling WiFi LED via firmware, and turns the LED on
>> >> and off when the interface is up and down accordingly.
>> >>
>> >> Signed-off-by: Wen-chien Jesse Sung <jesse.sung at canonical.com>
>> >> Tested-by: Gavin Lin <gavin.lin at canonical.com>
>> >> Reviewed-by: Keng-Yu Lin <kengyu at canonical.com>
>> >
>> > mac80211 already has led-trigger support for this sort of thing. Is
>> > there some reason that can't be utilized instead of hacking up the
>> > driver like this?
>>
>> Humm.. This patch is based on a solution provided by Marvell.
>> If led_trigger is preferred, I'll work on it.
>
> I'm not sure whether or not the LED integration in mac80211 can provide
> what you want or not, I just wanted to know if you had considered it.
> If it doesn't then I don't have any big objections to the mwifiex
> changes, though I'm not crazy about the DMI stuff.

I'll look into it and see it can be done with led_trigger.

> The btusb changes are more troublesome though because that's a very
> generic driver, not hardware-specific like mwifiex.

All of the changes in btusb would not have effect if it's not run on
Edge Gateway.
is_edge_gateway in btusb_data would only be set when the dmi_match() returns
true, and new code executes only when is_edge_gateway is true.

>
> Seth

Thanks,
Jesse