NAK{T,U,V,W}, ACK{X}: [SRU][Trusty][Wily][Xenial][lts-u][lts-v][PATCH 0/1] Input: xpad - correctly handle concurrent LED and FF requests

[Kamal Mostafa]

On Fri, Apr 08, 2016 at 04:06:07PM -0400, Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1564901
> 
> == SRU Justification ==
> xpad rumble causes full system hang.  
> 
> The bug can be reproduced by playing the game Borderlands 2 while having a wired 
> xbox controller connected. The system will randomly freeze.
> 
> Mainline commit 7fc595f4c02636eadaeeecfe7bbc45b57c173004 fixes this bug.  It is in
> mainline as of 4.6-rc1.  It cherry picks and builds cleanly.

This patch (7fc595f) applies fine on Xenial, but fails to apply (badly)
on all kernels <= Wily.  However ...

The bug reporter in 1564901 says "The bug has existed since at least
14.04."

Also note this duplicate bug (against Wily):
https://bugs.launchpad.net/wily-backports/+bug/1545222
"[fixed-upstream] Kernel Input: xpad - correctly handle concurrent LED
    and FF requests Edit"

This patch (7fc595f) makes reference to a 2014 patch which was the
original proposed fix for this crash:
http://www.spinics.net/lists/linux-input/msg31450.html
... and that patch does at least apply (to Trusty) with some fuzz.

Joseph, I suggest that you cook up test kernel(s) with that applied.
Note that the spinics link there hides the author email address, so
we'd need to locate the real original version of the patch before we
could actually merge it.

 -Kamal


> 
> == Fix ==
> commit 7fc595f4c02636eadaeeecfe7bbc45b57c173004
> Author: Pavel Rojtberg <rojtberg at gmail.com>
> Date:   Wed Dec 9 11:57:01 2015 -0800
> 
>     Input: xpad - correctly handle concurrent LED and FF requests
> 
> 
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
> 
> 
> 
> Pavel Rojtberg (1):
>   Input: xpad - correctly handle concurrent LED and FF requests
> 
>  drivers/input/joystick/xpad.c | 322 +++++++++++++++++++++++++++++-------------
>  1 file changed, 223 insertions(+), 99 deletions(-)
> 
> -- 
> 2.7.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team