[X/Y/Z][PATCH 0/2] Driver for Exar usb uart devices

[Jesse Sung]

2016-11-30 19:04 GMT+08:00 Jesse Sung <jesse.sung at canonical.com>:
> 2016-11-30 4:17 GMT+08:00 Tim Gardner <tim.gardner at canonical.com>:
>> On 11/29/2016 08:38 AM, Jesse Sung wrote:
>>> 2016-11-29 22:14 GMT+08:00 Tim Gardner <tim.gardner at canonical.com>:
>>>> On 11/29/2016 02:23 AM, Wen-chien Jesse Sung wrote:
>>>>> BugLink: https://launchpad.net/bugs/1645591
>>>>>
>>>>> The first commit contains the vendor driver found at
>>>>> https://www.exar.com/design-tools/software-drivers
>>>>> The .c and .h files are processed by indent before committing since they're
>>>>> not following the coding style, but otherwise I try to keep it as-is.
>>>>>
>>>>> The second commit adds an interface so user can change the mode between RS232
>>>>> and RS422/485.
>>>>>
>>>>> Darren Wu (1):
>>>>>   UBUNTU: SAUCE: xr-usb-serial: interface for switching modes
>>>>>
>>>>> Wen-chien Jesse Sung (1):
>>>>>   UBUNTU: SAUCE: xr-usb-serial: Driver for EXAR serial ports
>>>>>
>>>>>  ubuntu/Makefile                             |    4 +
>>>>>  ubuntu/xr-usb-serial/Makefile               |   15 +
>>>>>  ubuntu/xr-usb-serial/README.txt             |   50 +
>>>>>  ubuntu/xr-usb-serial/xr_usb_serial_common.c | 1883 +++++++++++++++++++++++++++
>>>>>  ubuntu/xr-usb-serial/xr_usb_serial_common.h |  182 +++
>>>>>  ubuntu/xr-usb-serial/xr_usb_serial_hal.c    |  779 +++++++++++
>>>>>  ubuntu/xr-usb-serial/xr_usb_serial_ioctl.h  |   31 +
>>>>>  7 files changed, 2944 insertions(+)
>>>>>  create mode 100644 ubuntu/xr-usb-serial/Makefile
>>>>>  create mode 100644 ubuntu/xr-usb-serial/README.txt
>>>>>  create mode 100644 ubuntu/xr-usb-serial/xr_usb_serial_common.c
>>>>>  create mode 100644 ubuntu/xr-usb-serial/xr_usb_serial_common.h
>>>>>  create mode 100644 ubuntu/xr-usb-serial/xr_usb_serial_hal.c
>>>>>  create mode 100644 ubuntu/xr-usb-serial/xr_usb_serial_ioctl.h
>>>>>
>>>>
>>>> I'm in agreement with Stefan. Why do we need this driver ?
>>>>
>>>> What are the prospects for upstreaming it ? Is it distributed in one
>>>> monolithic tarball ? If you reformat for coding style, then its gonna
>>>> make your life pretty difficult if/when there are updates.
>>>
>>> This device is used in an ubuntu core project which uses Xenial kernel (4.4).
>>> Secureboot is a requirement so make it into ubuntu kernel is the only
>>> option we have.
>>>
>>
>> So it isn't going upstream ?
>>
>
> Given that it was released back in 2015, guess they don't have plan to
> send it to upstream.
>

I learned yesterday that Exar will send the driver to upstream, though I don't
know the schedule of it.

>>> Reformatting is done by scripts/Lindent only, it should not be an
>>> issue to reformat
>>> any upcoming updates. I can re-do the patches if an untouched version
>>> is preferred.
>>
>> Leaving the original sources unformatted will certainly make it easier
>> to update as well as diff old v.s. new.
>>
>
> I'll send a v2 patchset with the original sources.
>
> Thanks,
> Jesse
>
>> rtg
>> --
>> Tim Gardner tim.gardner at canonical.com